ENG-4362 refactor validations and fix tech debt#1452
Open
ichalagashvili wants to merge 1 commit intodevelopfrom
Open
ENG-4362 refactor validations and fix tech debt#1452ichalagashvili wants to merge 1 commit intodevelopfrom
ichalagashvili wants to merge 1 commit intodevelopfrom
Conversation
|
Requested publication of version |
Dv92
reviewed
Feb 1, 2023
Comment on lines
-12
to
13
|
|
||
| const maxLength10 = maxLength(10); | ||
| const maxLength15 = maxLength(15); | ||
| const maxLength50 = maxLength(50); |
Contributor
There was a problem hiding this comment.
changing this value seems have a global impact to other part of the code that use AttributeInfo. Are you sure that this doesn't cause bug in other sections?
Dv92
approved these changes
Feb 7, 2023
DMinnai
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minLength10tominLength15for Profile Type Attribute code size, sinceprofilepicturehas length of 14 and its a default attribute.fieldrenderer with existingUserProfileFieldand deleted repeated code.fyi: the other PR was closed as it had incorrect solution